Removes explicit dependency on DoctrineBundle. #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency is implicitly provided by symfony/orm-pack.
|
@phpeek thanks for this. I'm going to merge it because it's the right thing to do now. However, we're thinking of getting rid of "packs" on composer.json. You will still do "composer require ...pack", but we're thinking about "unfolding" the pack and adding the real dependencies on your composer.json, because that's easier to understand. If this idea is implemented, we'd need to do the opposite change ... add DoctrineBundle and remove the ORM pack. We'll see :) |
javiereguiluz
added a commit
that referenced
this pull request
Dec 3, 2017
This PR was merged into the master branch. Discussion ---------- Removes explicit dependency on DoctrineBundle. This dependency is implicitly provided by `symfony/orm-pack`. Commits ------- fa3b3d5 Removes explicit dependency on DoctrineBundle.
|
@javiereguiluz I'm very glad to hear You guys are planning to turn |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is implicitly provided by
symfony/orm-pack.