Remove explicit var-dumper #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you require symfony/profiler-pack, there's no need to require symfony/var-dump (that is required by symfony/web-profiler-bundle, that is required by symfony/profiler-pack)
|
Something related to #716 (comment) Btw, do you have a link to that discussion @javiereguiluz ? Or is it something internal? |
|
It was an internal discussion, so I can't link to it. Sorry. |
|
np! just wonder how it will go |
|
I'm 👍 on this. Until packs unfolding feature comes this is the right thing to do IMO. @garak Please run |
|
Travis fixed |
|
Let's merge this! But "unpacking packs" is coming very soon to Flex: symfony/flex#241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you require symfony/profiler-pack, there's no need to require symfony/var-dump (that is required by symfony/web-profiler-bundle, that is required by symfony/profiler-pack)