-
-
Notifications
You must be signed in to change notification settings - Fork 424
[reset-password] Coding standards - Twig #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! The changes look good, could you rebase this PR please. We've fixed a number of broken tests since you've opened the PR. Thanks in advanced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seb-jean!
Thanks @seb-jean! |
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep v1.37.0 # RELEASE Hi Makers! This release handles several bug fixes within MakerBundle and adds support for translating ResetPasswordBundle Exception messages, using constants instead of strings with `make:voter`, improved types for `Collection` getter methods in Entities, and support for attributes in `make:registration`! Diff: v1.36.4...v1.37.0 Happy making! --- # CHANGELOG ## [v1.37.0](https://github.com/symfony/maker-bundle/releases/tag/v1.37.0) *February 15th, 2022* ### Feature - [#1062](#1062) - [MakeRegistration] add support for verify email attributes - *`@jrushlow`* - [#1059](#1059) - [make:reset-password] Translate exception reasons provided by ResetPasswordBundle - *`@bocharsky`-bw* - [#1057](#1057) - [Voter] Refactor attributes - *`@mdoutreluingne`* - [#1040](#1040) - [make:entity] Chaing getter PHPDoc return type on Collection - *`@mehdibo`* ### Bug Fix - [#1060](#1060) - Add missing Passport use statement - *`@bocharsky`-bw* - [#1032](#1032) - [reset-password] Coding standards - Twig - *`@seb`-jean* - [#1031](#1031) - [verify-email] Coding standards - Twig - *`@seb`-jean* - [#1027](#1027) - Fixing wrong messaging in make:auth about checking password in final steps - *`@weaverryan`* - [#985](#985) - [make:auth] fix security controller attributes - *`@jrushlow`* Commits ------- 52063a9 [release] prep v1.37.0
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep v1.37.0 # RELEASE Hi Makers! This release handles several bug fixes within MakerBundle and adds support for translating ResetPasswordBundle Exception messages, using constants instead of strings with `make:voter`, improved types for `Collection` getter methods in Entities, and support for attributes in `make:registration`! Diff: symfony/maker-bundle@v1.36.4...v1.37.0 Happy making! --- # CHANGELOG ## [v1.37.0](https://github.com/symfony/maker-bundle/releases/tag/v1.37.0) *February 15th, 2022* ### Feature - [#1062](symfony/maker-bundle#1062) - [MakeRegistration] add support for verify email attributes - *`@jrushlow`* - [#1059](symfony/maker-bundle#1059) - [make:reset-password] Translate exception reasons provided by ResetPasswordBundle - *`@bocharsky`-bw* - [#1057](symfony/maker-bundle#1057) - [Voter] Refactor attributes - *`@mdoutreluingne`* - [#1040](symfony/maker-bundle#1040) - [make:entity] Chaing getter PHPDoc return type on Collection - *`@mehdibo`* ### Bug Fix - [#1060](symfony/maker-bundle#1060) - Add missing Passport use statement - *`@bocharsky`-bw* - [#1032](symfony/maker-bundle#1032) - [reset-password] Coding standards - Twig - *`@seb`-jean* - [#1031](symfony/maker-bundle#1031) - [verify-email] Coding standards - Twig - *`@seb`-jean* - [#1027](symfony/maker-bundle#1027) - Fixing wrong messaging in make:auth about checking password in final steps - *`@weaverryan`* - [#985](symfony/maker-bundle#985) - [make:auth] fix security controller attributes - *`@jrushlow`* Commits ------- 52063a93 [release] prep v1.37.0
Hi,
I changed the case to be like the standard coding:
https://twig.symfony.com/doc/3.x/coding_standards.html