[MakeRegistration] add support for verify email attributes #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
fix/ci-make-registration
branch
3 times, most recently
from
b70e8be to
88e248f
Compare
jrushlow
changed the title
jrushlow
force-pushed
the
fix/ci-make-registration
branch
from
4c09f67 to
a3740d7
Compare
jrushlow
changed the title
|
Tests are needed for CSM |
weaverryan
reviewed
Feb 15, 2022
jrushlow
commented
Feb 15, 2022
| @@ -358,6 +367,17 @@ public function addProperty(string $name, array $annotationLines = [], $defaultV | |||
| $this->addNodeAfterProperties($newPropertyNode); | |||
| } | |||
|
|
|||
| public function addAttributeToClass(string $attributeClass, array $options): void | |||
There was a problem hiding this comment.
Adding a class level attribute that requires an aliased use statement, e.g. use Doctrine\Mapping as ORM is not possible in this scope without refactoring the ClassSourceManipulator::addUseStatementIfNecessary() method. A task which is not required by our current use case and should be handled in a separate PR.
jrushlow
force-pushed
the
fix/ci-make-registration
branch
from
b23f382 to
bb92ef7
Compare
|
Thanks Jesse! |
Merged
weaverryan
added a commit
that referenced
this pull request
Feb 16, 2022
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep v1.37.0 # RELEASE Hi Makers! This release handles several bug fixes within MakerBundle and adds support for translating ResetPasswordBundle Exception messages, using constants instead of strings with `make:voter`, improved types for `Collection` getter methods in Entities, and support for attributes in `make:registration`! Diff: v1.36.4...v1.37.0 Happy making! --- # CHANGELOG ## [v1.37.0](https://github.com/symfony/maker-bundle/releases/tag/v1.37.0) *February 15th, 2022* ### Feature - [#1062](#1062) - [MakeRegistration] add support for verify email attributes - *`@jrushlow`* - [#1059](#1059) - [make:reset-password] Translate exception reasons provided by ResetPasswordBundle - *`@bocharsky`-bw* - [#1057](#1057) - [Voter] Refactor attributes - *`@mdoutreluingne`* - [#1040](#1040) - [make:entity] Chaing getter PHPDoc return type on Collection - *`@mehdibo`* ### Bug Fix - [#1060](#1060) - Add missing Passport use statement - *`@bocharsky`-bw* - [#1032](#1032) - [reset-password] Coding standards - Twig - *`@seb`-jean* - [#1031](#1031) - [verify-email] Coding standards - Twig - *`@seb`-jean* - [#1027](#1027) - Fixing wrong messaging in make:auth about checking password in final steps - *`@weaverryan`* - [#985](#985) - [make:auth] fix security controller attributes - *`@jrushlow`* Commits ------- 52063a9 [release] prep v1.37.0
saylor-mik87786
added a commit
to saylor-mik87786/maker-bundle
that referenced
this pull request
Jun 3, 2025
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep v1.37.0 # RELEASE Hi Makers! This release handles several bug fixes within MakerBundle and adds support for translating ResetPasswordBundle Exception messages, using constants instead of strings with `make:voter`, improved types for `Collection` getter methods in Entities, and support for attributes in `make:registration`! Diff: symfony/maker-bundle@v1.36.4...v1.37.0 Happy making! --- # CHANGELOG ## [v1.37.0](https://github.com/symfony/maker-bundle/releases/tag/v1.37.0) *February 15th, 2022* ### Feature - [#1062](symfony/maker-bundle#1062) - [MakeRegistration] add support for verify email attributes - *`@jrushlow`* - [#1059](symfony/maker-bundle#1059) - [make:reset-password] Translate exception reasons provided by ResetPasswordBundle - *`@bocharsky`-bw* - [#1057](symfony/maker-bundle#1057) - [Voter] Refactor attributes - *`@mdoutreluingne`* - [#1040](symfony/maker-bundle#1040) - [make:entity] Chaing getter PHPDoc return type on Collection - *`@mehdibo`* ### Bug Fix - [#1060](symfony/maker-bundle#1060) - Add missing Passport use statement - *`@bocharsky`-bw* - [#1032](symfony/maker-bundle#1032) - [reset-password] Coding standards - Twig - *`@seb`-jean* - [#1031](symfony/maker-bundle#1031) - [verify-email] Coding standards - Twig - *`@seb`-jean* - [#1027](symfony/maker-bundle#1027) - Fixing wrong messaging in make:auth about checking password in final steps - *`@weaverryan`* - [#985](symfony/maker-bundle#985) - [make:auth] fix security controller attributes - *`@jrushlow`* Commits ------- 52063a93 [release] prep v1.37.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniqueEntityattributes on theUserentity.Known Issues:
Adding a class level attribute that utilizes an aliased use statement, e.g.
use CLASS as PREFIXtype alias is not supported in this PR.