Add TwigBundle 6.4 with `file_name_pattern: *.twig` #1256

GromNaN · 2023-11-16T12:15:31Z

Q	A
License	MIT
Doc issue/PR	-

By default, Twig templates have the .twig extension. They can be collocated with other files (SVG, CSS, JS or even PHP for Twig Components)

Adding the option twig.file_name_pattern: '*.twig' by default for new projects is necessary to avoid compiling non-twig files.

Related to symfony/symfony#45845

github-actions · 2023-11-16T12:15:57Z

Thanks for the PR 😍

How to test these changes in your application

Define the SYMFONY_ENDPOINT environment variable:

# On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1256/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1256/index.json

Install the package(s) related to this recipe:

composer req 'symfony/flex:^1.16'
composer req 'symfony/twig-bundle:^6.4'

Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

# On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/twig-bundle

3.3 vs 4.4

diff --git a/symfony/twig-bundle/3.3/config/packages/twig.yaml b/symfony/twig-bundle/4.4/config/packages/twig.yaml
index d1582a2..6403e6a 100644
--- a/symfony/twig-bundle/3.3/config/packages/twig.yaml
+++ b/symfony/twig-bundle/4.4/config/packages/twig.yaml
@@ -2,3 +2,4 @@ twig:
     default_path: '%kernel.project_dir%/templates'
     debug: '%kernel.debug%'
     strict_variables: '%kernel.debug%'
+    exception_controller: null
diff --git a/symfony/twig-bundle/3.3/config/routes/dev/twig.yaml b/symfony/twig-bundle/3.3/config/routes/dev/twig.yaml
deleted file mode 100644
index f4ee839..0000000
--- a/symfony/twig-bundle/3.3/config/routes/dev/twig.yaml
+++ /dev/null
@@ -1,3 +0,0 @@
-_errors:
-    resource: '@TwigBundle/Resources/config/routing/errors.xml'
-    prefix: /_error

4.4 vs 5.0

diff --git a/symfony/twig-bundle/4.4/config/packages/twig.yaml b/symfony/twig-bundle/5.0/config/packages/twig.yaml
index 6403e6a..b3cdf30 100644
--- a/symfony/twig-bundle/4.4/config/packages/twig.yaml
+++ b/symfony/twig-bundle/5.0/config/packages/twig.yaml
@@ -1,5 +1,2 @@
 twig:
     default_path: '%kernel.project_dir%/templates'
-    debug: '%kernel.debug%'
-    strict_variables: '%kernel.debug%'
-    exception_controller: null

5.0 vs 5.3

diff --git a/symfony/twig-bundle/5.0/config/packages/test/twig.yaml b/symfony/twig-bundle/5.0/config/packages/test/twig.yaml
deleted file mode 100644
index 8c6e0b4..0000000
--- a/symfony/twig-bundle/5.0/config/packages/test/twig.yaml
+++ /dev/null
@@ -1,2 +0,0 @@
-twig:
-    strict_variables: true
diff --git a/symfony/twig-bundle/5.0/config/packages/twig.yaml b/symfony/twig-bundle/5.3/config/packages/twig.yaml
index b3cdf30..f9f4cc5 100644
--- a/symfony/twig-bundle/5.0/config/packages/twig.yaml
+++ b/symfony/twig-bundle/5.3/config/packages/twig.yaml
@@ -1,2 +1,6 @@
 twig:
     default_path: '%kernel.project_dir%/templates'
+
+when@test:
+    twig:
+        strict_variables: true
diff --git a/symfony/twig-bundle/5.0/manifest.json b/symfony/twig-bundle/5.3/manifest.json
index 30d5643..c4835ac 100644
--- a/symfony/twig-bundle/5.0/manifest.json
+++ b/symfony/twig-bundle/5.3/manifest.json
@@ -5,5 +5,8 @@
     "copy-from-recipe": {
         "config/": "%CONFIG_DIR%/",
         "templates/": "templates/"
+    },
+    "conflict": {
+        "symfony/framework-bundle": "<5.3"
     }
 }

5.3 vs 5.4

diff --git a/symfony/twig-bundle/5.3/templates/base.html.twig b/symfony/twig-bundle/5.4/templates/base.html.twig
index 16d7273..d4f83f7 100644
--- a/symfony/twig-bundle/5.3/templates/base.html.twig
+++ b/symfony/twig-bundle/5.4/templates/base.html.twig
@@ -3,14 +3,14 @@
     <head>
         <meta charset="UTF-8">
         <title>{% block title %}Welcome!{% endblock %}</title>
-        {# Run `composer require symfony/webpack-encore-bundle`
-           and uncomment the following Encore helpers to start using Symfony UX #}
+        <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">
+        {# Run `composer require symfony/webpack-encore-bundle` to start using Symfony UX #}
         {% block stylesheets %}
-            {#{{ encore_entry_link_tags('app') }}#}
+            {{ encore_entry_link_tags('app') }}
         {% endblock %}
 
         {% block javascripts %}
-            {#{{ encore_entry_script_tags('app') }}#}
+            {{ encore_entry_script_tags('app') }}
         {% endblock %}
     </head>
     <body>

5.4 vs 6.3

diff --git a/symfony/twig-bundle/5.4/templates/base.html.twig b/symfony/twig-bundle/6.3/templates/base.html.twig
index d4f83f7..67598ac 100644
--- a/symfony/twig-bundle/5.4/templates/base.html.twig
+++ b/symfony/twig-bundle/6.3/templates/base.html.twig
@@ -4,13 +4,10 @@
         <meta charset="UTF-8">
         <title>{% block title %}Welcome!{% endblock %}</title>
         <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">
-        {# Run `composer require symfony/webpack-encore-bundle` to start using Symfony UX #}
         {% block stylesheets %}
-            {{ encore_entry_link_tags('app') }}
         {% endblock %}
 
         {% block javascripts %}
-            {{ encore_entry_script_tags('app') }}
         {% endblock %}
     </head>
     <body>

6.3 vs 6.4

diff --git a/symfony/twig-bundle/6.3/config/packages/twig.yaml b/symfony/twig-bundle/6.4/config/packages/twig.yaml
index f9f4cc5..3f795d9 100644
--- a/symfony/twig-bundle/6.3/config/packages/twig.yaml
+++ b/symfony/twig-bundle/6.4/config/packages/twig.yaml
@@ -1,5 +1,5 @@
 twig:
-    default_path: '%kernel.project_dir%/templates'
+    file_name_pattern: '*.twig'
 
 when@test:
     twig:
diff --git a/symfony/twig-bundle/6.3/templates/base.html.twig b/symfony/twig-bundle/6.4/templates/base.html.twig
index 67598ac..1069c14 100644
--- a/symfony/twig-bundle/6.3/templates/base.html.twig
+++ b/symfony/twig-bundle/6.4/templates/base.html.twig
@@ -3,7 +3,7 @@
     <head>
         <meta charset="UTF-8">
         <title>{% block title %}Welcome!{% endblock %}</title>
-        <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">
+        <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text><text y=%221.3em%22 x=%220.2em%22 font-size=%2276%22 fill=%22%23fff%22>sf</text></svg>">
         {% block stylesheets %}
         {% endblock %}

GromNaN · 2023-11-16T12:20:05Z

symfony/twig-bundle/6.4/templates/base.html.twig

+    <head>
+        <meta charset="UTF-8">
+        <title>{% block title %}Welcome!{% endblock %}</title>
+        <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">


Do you know why we use this sober emoji instead of something more fun like ⭐ or 🎯.

It looks like the sf logo... but without sf 😂

also, projects must change their favicon to use their own anyway. Having a default one here avoids getting 404 errors when browsers try to load a default favicon.ico file otherwise.

Oh! Let's add the sf then.

Suggested change

<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">

<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text><text y=%221.3em%22 x=%220.2em%22 font-size=%2276%22 fill=%22%23fff%22>sf</text></svg>">

Chrome

Firefox

I like the idea of making a icon from an emoji. It makes it very easy to anyone starting a project to use something from the existing emojis.

stof · 2023-11-16T15:53:52Z

symfony/twig-bundle/6.4/config/packages/twig.yaml

@@ -0,0 +1,7 @@
+twig:
+    default_path: '%kernel.project_dir%/templates'


isn't this the default already in TwigBundle ? If yes, I suggest removing the explicit config duplicating it, to simplify things.

yes, it's already the case

I'll remove this config as it is the default value: https://github.com/symfony/symfony/blob/v6.4.0-RC1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L145C33-L145C33

We have a few settings that are just the defaults to show how to override things. This is one of them. Maybe not that frequent, I just wanted to highlight why it was there.

https://github.com/symfony/symfony/blob/v6.4.0-RC1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L145C33-L145C33

GromNaN · 2023-11-16T16:15:57Z

symfony/twig-bundle/6.4/manifest.json

+        "templates/": "templates/"
+    },
+    "conflict": {
+        "symfony/framework-bundle": "<5.3"


Is it still necessary? The bundle has a conflict rule with symfony/framework-bundle <5.4

OskarStark · 2023-11-16T16:34:09Z

Related to #45845

Is not clickable

Add TwigBundle 6.4 with file_name_pattern=*.twig

1848542

GromNaN requested a review from weaverryan November 16, 2023 12:15

symfony-recipes-bot enabled auto-merge (squash) November 16, 2023 12:15

GromNaN commented Nov 16, 2023

View reviewed changes

stof reviewed Nov 16, 2023

View reviewed changes

symfony deleted a comment from yceruto Nov 16, 2023

Remove twig.default_path as it's already the default value

4d77e1b

https://github.com/symfony/symfony/blob/v6.4.0-RC1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L145C33-L145C33

GromNaN commented Nov 16, 2023

View reviewed changes

Add "sf" to the favicon to look like the Symfony logo

d98e304

fabpot approved these changes Jan 20, 2024

View reviewed changes

OskarStark approved these changes Jan 20, 2024

View reviewed changes

symfony-recipes-bot merged commit 46a908b into symfony:main Jan 20, 2024

GromNaN deleted the twig-6.4 branch February 22, 2024 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add TwigBundle 6.4 with `file_name_pattern: *.twig` #1256

Add TwigBundle 6.4 with `file_name_pattern: *.twig` #1256

Uh oh!

GromNaN commented Nov 16, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Nov 16, 2023 •

edited

Loading

Uh oh!

GromNaN Nov 16, 2023

Uh oh!

fabpot Jan 18, 2024

Uh oh!

stof Jan 18, 2024

Uh oh!

GromNaN Jan 18, 2024

Uh oh!

GromNaN Jan 18, 2024 •

edited

Loading

Uh oh!

stof Nov 16, 2023

Uh oh!

yceruto Nov 16, 2023

Uh oh!

GromNaN Nov 16, 2023 •

edited

Loading

Uh oh!

fabpot Jan 18, 2024

Uh oh!

GromNaN Nov 16, 2023

Uh oh!

OskarStark commented Nov 16, 2023

Uh oh!

Uh oh!

	<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>">
	<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text><text y=%221.3em%22 x=%220.2em%22 font-size=%2276%22 fill=%22%23fff%22>sf</text></svg>">

		@@ -0,0 +1,7 @@
		twig:
		default_path: '%kernel.project_dir%/templates'

Uh oh!

Add TwigBundle 6.4 with file_name_pattern: *.twig #1256

Add TwigBundle 6.4 with file_name_pattern: *.twig #1256

Uh oh!

Conversation

GromNaN commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test these changes in your application

Diff between recipe versions

symfony/twig-bundle

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GromNaN Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GromNaN Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OskarStark commented Nov 16, 2023

Uh oh!

Uh oh!

Add TwigBundle 6.4 with `file_name_pattern: *.twig` #1256

Add TwigBundle 6.4 with `file_name_pattern: *.twig` #1256

GromNaN commented Nov 16, 2023 •

edited

Loading

github-actions bot commented Nov 16, 2023 •

edited

Loading

GromNaN Jan 18, 2024 •

edited

Loading

GromNaN Nov 16, 2023 •

edited

Loading