Add TwigBundle 6.4 with file_name_pattern: *.twig
#1256
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| twig: | ||
| default_path: '%kernel.project_dir%/templates' | ||
| file_name_pattern: '*.twig' | ||
|
|
||
| when@test: | ||
| twig: | ||
| strict_variables: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "bundles": { | ||
| "Symfony\\Bundle\\TwigBundle\\TwigBundle": ["all"] | ||
| }, | ||
| "copy-from-recipe": { | ||
| "config/": "%CONFIG_DIR%/", | ||
| "templates/": "templates/" | ||
| }, | ||
| "conflict": { | ||
| "symfony/framework-bundle": "<5.3" | ||
|
There was a problem hiding this comment. Is it still necessary? The bundle has a conflict rule with |
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| <!DOCTYPE html> | ||||||
| <html> | ||||||
| <head> | ||||||
| <meta charset="UTF-8"> | ||||||
| <title>{% block title %}Welcome!{% endblock %}</title> | ||||||
| <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 128 128%22><text y=%221.2em%22 font-size=%2296%22>⚫️</text></svg>"> | ||||||
|
There was a problem hiding this comment. Do you know why we use this sober emoji instead of something more fun like ⭐ or 🎯. There was a problem hiding this comment. It looks like the sf logo... but without sf 😂 There was a problem hiding this comment. also, projects must change their favicon to use their own anyway. Having a default one here avoids getting 404 errors when browsers try to load a default There was a problem hiding this comment. Oh! Let's add the
Suggested change
Chrome Firefox There was a problem hiding this comment. I like the idea of making a icon from an emoji. It makes it very easy to anyone starting a project to use something from the existing emojis. |
||||||
| {% block stylesheets %} | ||||||
| {% endblock %} | ||||||
|
|
||||||
| {% block javascripts %} | ||||||
| {% endblock %} | ||||||
| </head> | ||||||
| <body> | ||||||
| {% block body %}{% endblock %} | ||||||
| </body> | ||||||
| </html> | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the default already in TwigBundle ? If yes, I suggest removing the explicit config duplicating it, to simplify things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's already the case
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this config as it is the default value: https://github.com/symfony/symfony/blob/v6.4.0-RC1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L145C33-L145C33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a few settings that are just the defaults to show how to override things. This is one of them. Maybe not that frequent, I just wanted to highlight why it was there.