Skip to content

Add intro note to services.yaml and routes.yaml #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 1, 2018
Merged

Add intro note to services.yaml and routes.yaml #426

1 commit merged into from
Jul 1, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT

Fixes symfony/symfony-docs#9285

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 3567ee2 into symfony:master Jul 1, 2018
ghost pushed a commit that referenced this pull request Jul 1, 2018
@@ -1,3 +1,6 @@
# This file is the entry point to configure your own services.
# Files in the packages/ subdirectory configure your dependencies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. You can store your own configuration under packages/ as well. There is no restrictions. People are free to organize their config as they see fit (same for the routing).

Copy link
Contributor

@ogizanagi ogizanagi Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it as a hint, not explaining a restriction but rather that dependencies you install are providing their config & routes in the packages/ and routes/ directories. Perhaps the last sentence can be reversed to explain this more clearly.

Dependencies are providing their config in the packages/ subdirectory.

and mention you're free to tweak these anyway.

@nicolas-grekas nicolas-grekas deleted the config-notes branch July 2, 2018 13:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants