Skip to content

Add intro note to services.yaml and routes.yaml #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 1, 2018
Merged

Add intro note to services.yaml and routes.yaml #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions symfony/framework-bundle/3.3/config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# This file is the entry point to configure your own services.
# Files in the packages/ subdirectory configure your dependencies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. You can store your own configuration under packages/ as well. There is no restrictions. People are free to organize their config as they see fit (same for the routing).

Copy link
Contributor

@ogizanagi ogizanagi Jul 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it as a hint, not explaining a restriction but rather that dependencies you install are providing their config & routes in the packages/ and routes/ directories. Perhaps the last sentence can be reversed to explain this more clearly.

Dependencies are providing their config in the packages/ subdirectory.

and mention you're free to tweak these anyway.


# Put parameters here that don't need to change on each machine where the app is deployed
# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
parameters:
Expand Down
3 changes: 3 additions & 0 deletions symfony/routing/3.3/config/routes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# This file is the entry point to configure your own HTTP routes.
# Files in the routes/ subdirectory configure the routes for your dependencies.

#index:
# path: /
# defaults: { _controller: 'App\Controller\DefaultController::index' }