Skip to content

Documenting the WebpackEncoreBundle caching option #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 13, 2019
Merged

Documenting the WebpackEncoreBundle caching option #541

1 commit merged into from
Mar 13, 2019

Conversation

weaverryan
Copy link
Member

Q A
License MIT

See symfony/webpack-encore-bundle#12

This is only available in 1.2, but I don't see a good reason to duplicate the recipe - it's an opt-in feature (so it will always be commented-out by default) and even if you, somehow, installed an older version today, you will now be aware of this feature.

Thanks!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Pierstoval
Copy link
Contributor

Pierstoval commented Mar 1, 2019

I suggest to create a new recipe for 1.2 because composer sync-recipes --force could be used to reset the recipe, but if the person running the command has only 1.0 or 1.1, they might uncomment this line and end up with errors...

Of course they should upgrade anyway, but IMO this is not the best option to introduce a comment in a version not compatible with this option...

@weaverryan
Copy link
Member Author

We'll see what other's think :). If someone runs sync-recipes --force and they now have this new comment, that's great! They get to see a new option, with documentation that says that it is available in 1.2 of the bundle.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit d716ac8 into symfony:master Mar 13, 2019
ghost pushed a commit that referenced this pull request Mar 13, 2019
@weaverryan weaverryan deleted the encore-bundle-caching branch March 13, 2019 13:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants