Skip to content

[Webpack encore] Enable cache only in prod #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 10, 2019
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 6, 2019

Q A
License MIT

We made a mistake in #541

We should only enable cache when %kernel.debug% is NOT true.

#eu-fossa

@Nyholm Nyholm requested a review from weaverryan April 6, 2019 13:01
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

That's annoying to need to create an entirely separate file, just to effectively have !%kernel.debug% 🤔

@ghost ghost merged commit 11c60ac into symfony:master Apr 10, 2019
ghost pushed a commit that referenced this pull request Apr 10, 2019
@Nyholm Nyholm deleted the webpack branch April 11, 2019 12:35
@Nyholm
Copy link
Member Author

Nyholm commented Apr 11, 2019

Thank you for merging

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants