Skip to content

[LexikJWTAuthenticationBundle] Add aliases #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017

Conversation

ogizanagi
Copy link
Contributor

ping @chalasr

@@ -5,6 +5,7 @@
"copy-from-recipe": {
"etc/": "%ETC_DIR%"
},
"aliases": ["jwt-auth"],
Copy link
Member

@javiereguiluz javiereguiluz May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's decided that this bundle is "the JWT solution for Symfony", then we could even go for adding jwt too as an alias.

Copy link
Contributor Author

@ogizanagi ogizanagi May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted at first, but the bundle is a solution for setting a jwt authentication, not for consuming external jwt tokens for instance (even if it depends on libraries that will probably do natively).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the bundle is written on top of libraries like lcobucci/jwt, it is only about authentication while jwt can be used in different contexts. 👍 for jwt-auth

@fabpot
Copy link
Member

fabpot commented May 11, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 4da5639 into symfony:master May 11, 2017
fabpot added a commit that referenced this pull request May 11, 2017
This PR was merged into the master branch.

Discussion
----------

[LexikJWTAuthenticationBundle] Add aliases

ping @chalasr

Commits
-------

4da5639 [LexikJWTAuthenticationBundle] Add aliases
@ogizanagi ogizanagi deleted the lexikjwt/add_alias branch May 11, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants