-
-
Notifications
You must be signed in to change notification settings - Fork 497
[LexikJWTAuthenticationBundle] Add aliases #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -5,6 +5,7 @@ | |||
"copy-from-recipe": { | |||
"etc/": "%ETC_DIR%" | |||
}, | |||
"aliases": ["jwt-auth"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's decided that this bundle is "the JWT solution for Symfony", then we could even go for adding jwt
too as an alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted at first, but the bundle is a solution for setting a jwt authentication, not for consuming external jwt tokens for instance (even if it depends on libraries that will probably do natively).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the bundle is written on top of libraries like lcobucci/jwt, it is only about authentication while jwt can be used in different contexts. 👍 for jwt-auth
Thank you @ogizanagi. |
ping @chalasr