Skip to content

[LexikJWTAuthenticationBundle] Add aliases #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017
Merged

[LexikJWTAuthenticationBundle] Add aliases #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lexik/jwt-authentication-bundle/2.3/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"copy-from-recipe": {
"etc/": "%ETC_DIR%"
},
"aliases": ["jwt-auth"],
Copy link
Member

@javiereguiluz javiereguiluz May 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's decided that this bundle is "the JWT solution for Symfony", then we could even go for adding jwt too as an alias.

Copy link
Contributor Author

@ogizanagi ogizanagi May 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted at first, but the bundle is a solution for setting a jwt authentication, not for consuming external jwt tokens for instance (even if it depends on libraries that will probably do natively).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the bundle is written on top of libraries like lcobucci/jwt, it is only about authentication while jwt can be used in different contexts. 👍 for jwt-auth

"env": {
"JWT_PRIVATE_KEY_PATH": "%ETC_DIR%/jwt/private.pem",
"JWT_PUBLIC_KEY_PATH": "%ETC_DIR%/jwt/public.pem",
Expand Down