Add strict mode to webpack encore bundle #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
weaverryan
reviewed
Oct 31, 2019
symfony/webpack-encore-bundle/1.6/config/packages/webpack_encore.yaml
Outdated
Show resolved
Hide resolved
symfony/webpack-encore-bundle/1.6/config/packages/webpack_encore.yaml
Outdated
Show resolved
Hide resolved
symfony/webpack-encore-bundle/1.6/config/packages/test/webpack_encore.yaml
Outdated
Show resolved
Hide resolved
PabloKowalczyk
force-pushed
the
add-strict-mode-to-webpack-encore-bundle
branch
from
07619ce to
83b9cba
Compare
ghost
suggested changes
Nov 1, 2019
symfony/webpack-encore-bundle/1.6/config/packages/test/webpack_encore.yaml
Outdated
Show resolved
Hide resolved
…ted to fast change
PabloKowalczyk
force-pushed
the
add-strict-mode-to-webpack-encore-bundle
branch
from
83b9cba to
7e5e646
Compare
symfony/webpack-encore-bundle/1.6/config/packages/test/webpack_encore.yaml
Show resolved
Hide resolved
fabpot
approved these changes
Nov 17, 2019
weaverryan
approved these changes
Nov 17, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new options to WebpackEncoreBundle and disables
strict-modein test environment.EDIT: Ping @weaverryan