-
-
Notifications
You must be signed in to change notification settings - Fork 497
Add strict mode to webpack encore bundle #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
5 commits merged into
symfony:master
from
PabloKowalczyk:add-strict-mode-to-webpack-encore-bundle
Nov 17, 2019
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
30a48f2
Add new options to "webpack_encore.yaml"
PabloKowalczyk 99026bf
Disable strict_mode in test environment
PabloKowalczyk ca6e14d
Remove "available in version" comment
PabloKowalczyk 38c3d4c
Indent correctly
PabloKowalczyk 7e5e646
By default do not disable "strict_mode" for tests but leave it commen…
PabloKowalczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../1.0/assets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../1.0/config/packages/assets.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../1.0/config/packages/prod |
2 changes: 2 additions & 0 deletions
2
symfony/webpack-encore-bundle/1.6/config/packages/test/webpack_encore.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#webpack_encore: | ||
# strict_mode: false | ||
25 changes: 25 additions & 0 deletions
25
symfony/webpack-encore-bundle/1.6/config/packages/webpack_encore.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
webpack_encore: | ||
# The path where Encore is building the assets - i.e. Encore.setOutputPath() | ||
output_path: '%kernel.project_dir%/public/build' | ||
# If multiple builds are defined (as shown below), you can disable the default build: | ||
# output_path: false | ||
|
||
# if using Encore.enableIntegrityHashes() and need the crossorigin attribute (default: false, or use 'anonymous' or 'use-credentials') | ||
# crossorigin: 'anonymous' | ||
|
||
# preload all rendered script and link tags automatically via the http2 Link header | ||
# preload: true | ||
|
||
# Throw an exception if the entrypoints.json file is missing or an entry is missing from the data | ||
# strict_mode: false | ||
|
||
# if you have multiple builds: | ||
# builds: | ||
# pass "frontend" as the 3rg arg to the Twig functions | ||
# {{ encore_entry_script_tags('entry1', null, 'frontend') }} | ||
|
||
# frontend: '%kernel.project_dir%/public/frontend/build' | ||
|
||
# Cache the entrypoints.json (rebuild Symfony's cache when entrypoints.json changes) | ||
# Put in config/packages/prod/webpack_encore.yaml | ||
# cache: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../1.0/manifest.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../1.0/package.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../1.0/webpack.config.js |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.