the product category must be nullable #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Jul 9, 2018
doctrine/associations.rst
Outdated
| @@ -146,7 +146,7 @@ the ``Product`` entity (and getter & setter methods): | |||
|
|
|||
| /** | |||
| * @ORM\ManyToOne(targetEntity="App\Entity\Category", inversedBy="products") | |||
| * @ORM\JoinColumn(nullable=false) | |||
| * @ORM\JoinColumn(nullable=true) | |||
There was a problem hiding this comment.
In that case, the annotation can be removed (it's already the default value)
There was a problem hiding this comment.
@yceruto you meant remove the entire @ORM\JoinColumn instead of leaving it empty @ORM\JoinColumn(), right?
xabbuh
force-pushed
the
pr-9951
branch
2 times, most recently
from
3fe88eb to
27fdb54
Compare
|
Thank you! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 11, 2018
This PR was merged into the 4.0 branch. Discussion ---------- the product category must be nullable At first I wanted to sync the return type of `getCategory()` with the changes done in #9951. Though while looking at the rest of the chapter I noticed that we indeed call `setCategory()` with `null` in a follow-up example. So I decided to allow the property to become `null` instead. Commits ------- 31c5930 the product category must be nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I wanted to sync the return type of
getCategory()with the changes done in #9951. Though while looking at the rest of the chapter I noticed that we indeed callsetCategory()withnullin a follow-up example. So I decided to allow the property to becomenullinstead.