Updated associations.rst #9951
Closed
Updated associations.rst #9951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to reflect correct nullable status of $category.
carsonbot
added
Status: Needs Review
Status: Reviewed
and removed
Status: Needs Review
labels
HeahDude
approved these changes
Jun 22, 2018
|
@ansien12 thanks for this fix ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 11, 2018
This PR was merged into the 4.0 branch. Discussion ---------- the product category must be nullable At first I wanted to sync the return type of `getCategory()` with the changes done in #9951. Though while looking at the rest of the chapter I noticed that we indeed call `setCategory()` with `null` in a follow-up example. So I decided to allow the property to become `null` instead. Commits ------- 31c5930 the product category must be nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to reflect correct nullable status of $category.