Remove obsolete versionadded in 3.4 #11080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes symfony#11073). Discussion ---------- use correct code-block <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 7ff8c9b use correct code-block
This PR was merged into the 3.4 branch. Discussion ---------- Minor "Review comments" tweaks Just some minor consistency tweaks & typo fixes :) Commits ------- a1bd4ee Minor "Review comments" tweaks
…behaves like version… (OskarStark) This PR was merged into the 3.4 branch. Discussion ---------- removed versionadded, fixed count and note which behaves like version… …added <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 04ac2c7 removed versionadded, fixed count and note which behaves like versionadded
OskarStark
force-pushed
the
remove-obsolete-versionadded-in-3.4
branch
from
c1bfae8 to
8978214
Compare
OskarStark
force-pushed
the
remove-obsolete-versionadded-in-3.4
branch
from
8978214 to
914500e
Compare
|
Is it possible that this PR has some wrong commits? It looks a bit strange now. Thanks. |
|
Will check later 👍🏻 |
HeahDude
reviewed
Mar 5, 2019
| @@ -91,34 +91,34 @@ Don't use hyperbole ("always", "never", "endlessly", "nothing", "worst", "horrib | |||
| **Don't:** *"I don't like how you wrote this code"* - there is no clear explanation why you | |||
| don't like how it's written. | |||
|
|
|||
| **Better:** *"I find it hard to read this code as there many nested if statements, can you make it more | |||
| readable? By encapsulating some of it's details or maybe adding some comments to explain the overall logic."* - | |||
| **Better:** *"I find it hard to read this code as there is many nested if statements, can you make it more | |||
| **Better:** *"I find it hard to read this code as there many nested if statements, can you make it more | ||
| readable? By encapsulating some of it's details or maybe adding some comments to explain the overall logic."* - | ||
| **Better:** *"I find it hard to read this code as there is many nested if statements, can you make it more | ||
| readable? By encapsulating some of its details or maybe adding some comments to explain the overall logic."* - |
|
|
||
| * ``Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints.``. | ||
| * "Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints." |
|
|
||
| * Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``) | ||
| * "Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)" |
There was a problem hiding this comment.
Can be removed now I guess
|
Also we should target 3.4 here. |
|
Then remove useless notices in another PR targetting 4.2. |
Merged
Hmm you are right, lets close it for now, I will check that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.