Skip to content

small wording fixes #11094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

small wording fixes #11094

merged 1 commit into from
Mar 7, 2019

Conversation

OskarStark
Copy link
Contributor

Thanks @HeahDude I applied your comments from my other PR.

@OskarStark
Copy link
Contributor Author

@HeahDude

  1. You mentioned we should remove this:
    * "Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)"

But we should keep it, as of now it doesn't match Symfony CS if you use array(), and therefore its correct.

@OskarStark
Copy link
Contributor Author

OskarStark commented Mar 6, 2019 •
edited
Loading

@HeahDude

  1. You mentioned the? and I don't get it 😄 :

screenshot 2019-03-06 12 10 36

I created this PR and added your comments here as questions, because I will target the correct branch in my PR (#11080) and do a rebase, so your comments would get lost

@OskarStark OskarStark changed the title wording fixes small wording fixes Mar 6, 2019
@HeahDude HeahDude added this to the 3.4 milestone Mar 6, 2019
@HeahDude
Copy link
Contributor

HeahDude commented Mar 6, 2019

I meant, what about:

-readable? By encapsulating some of its details or maybe adding some
+readable? By encapsulating some of the details or maybe adding some

?

@javiereguiluz javiereguiluz merged commit f0a7926 into symfony:3.4 Mar 7, 2019
javiereguiluz added a commit that referenced this pull request Mar 7, 2019
@javiereguiluz
minor #11094 small wording fixes (OskarStark)
cb41807 
This PR was merged into the 3.4 branch.

Discussion
----------

small wording fixes

Thanks @HeahDude I applied your comments from my other PR.

Commits
-------

f0a7926 wording fixes
@javiereguiluz
Copy link
Member

Thanks Oskar! I made the pending change mentioned by Jules while merging.

@OskarStark OskarStark deleted the text-fixes branch March 7, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @HeahDude @javiereguiluz @carsonbot