validation config path #11949
Merged
validation config path #11949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wouterj I would like to have your review here, thank you! |
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes symfony#11024). Discussion ---------- [HTTP-cache] Added SSI Hello! This is my first "big" contribution to Symfony docs. :) It has many similarities with the ESI one but I think it can be better known and used with a specific doc. I think it's Symfony 2.6 (!) when the SSI feature has been merged, I hope I'm right. I guess there are many typos, I'll fix them as quickly as possible. Thanks for reviewing. ;) Commits ------- d9cdb9d add http cache SSI
This PR was merged into the 4.3 branch. Discussion ---------- Use https for xsd <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- bc76dbc Use https for xsd
wouterj
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Hi there! Thanks for submitting a perfectly valid PR (code ref). Sorry for our very slow responses.
I'm not so sure about the section added to the end of the article. I don't think it's common for people to modify the directory files are searched in. However, during the merge of this PR, we can move those contents to https://symfony.com/doc/current/reference/configuration/framework#reference-validation-mapping (as I think your example + text is better than what we currently have there).
and redirect it to `/bundles/override` as this was already deprecated in 3.4
This PR was merged into the 4.3 branch. Discussion ---------- Remove bundles inheritance page and redirect it to `/bundles/override` as this was already deprecated in 3.4 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2b75334 Remove bundles inheritance page
This PR was merged into the 3.4 branch. Discussion ---------- Add a note for preload asset This PR add a note about how to preload asset in Sf 3.4. Indeed it was not explained. There was just a symfony blog article about it : https://symfony.com/blog/new-in-symfony-3-3-asset-preloading-with-http-2-push Moreover `preload('build/style.css', { as: 'style' })` generates a good link in Sf4 but not in sf3 (relative instead of absolute). I think is confusing. I hope it can help other developers. Commits ------- d9b88d7 Add a note for preload asset
* 3.4: Tweaks symfony#12179 Add a note for preload asset
… (brambaud) This PR was merged into the 3.4 branch. Discussion ---------- add support for custom headers when using a proxy <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> See symfony/symfony#32961 and symfony/symfony#26333. We should document how to use custom headers when using reverse proxies since `Request::setTrustedHeaderName()` has been deprecated. Commits ------- a63c5a6 add support for custom headers when using a proxy
* 3.4: Tweaks symfony#12117 add support for custom headers when using a proxy
…one) This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3 branch instead (closes symfony#11157). Discussion ---------- [REFACTOR] Messenger - Serializer groups Hi everyone, I've faced some problems yesterday due to groups definition (mainly about embedded objects) and I think it could be a good idea to add a tip (or even a note?) about the `groups` usage. Any idea? Thanks :) Commits ------- bea832f [REFACTOR] Messenger - Serializer groups
… (javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Fixes the examples related to metadata Fixes symfony#11473. All credit goes to @carherco, who created the original pull request. Commits ------- 3c94eed [Workflow] Fixes the examples related to metadata
This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes symfony#12355). Discussion ---------- Mentioned the toStream() method Fixes symfony#11910. Commits ------- 1c1c590 Mentioned the toStream() method
…es Pietri) This PR was merged into the 3.4 branch. Discussion ---------- Improved documentation about access controls <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- a6b0959 Improved documentation about access controls
* 3.4: Improved documentation about access controls
… Mocking (benjamintoussaint) This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes symfony#12330). Discussion ---------- Inform about how to use new DateTime() when Clock Mocking <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 8212a62 Inform about how to use new DateTime() when Clock Mocking
* 3.4: Inform about how to use new DateTime() when Clock Mocking
* 3.4: Fixed minor issues
…d (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Reword a phrase to remove the "basic" word This fixes the error reported in symfony#12228. Commits ------- 7d70ce7 [Cache] Rewrod a phrase to remove the "basic" word
* 3.4: [Cache] Rewrod a phrase to remove the "basic" word
When looking at the docs, it seems that you can only use 1 file (validation.yaml|xml) for your validation config. Symfony looks for all the files in config/validator
javiereguiluz
force-pushed
the
patch-6
branch
from
b3b5579 to
643b1a9
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 24, 2019
This PR was submitted for the 4.2 branch but it was merged into the 4.3 branch instead (closes #11949). Discussion ---------- validation config path When looking at the docs, it seems that you can only use 1 file (validation.yaml|xml) for your validation config. Symfony looks for all the files in config/validator <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 643b1a9 Update validation.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the docs, it seems that you can only use 1 file (validation.yaml|xml) for your validation config.
Symfony looks for all the files in config/validator