Remove webserver bundle usage #13304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
approved these changes
Mar 4, 2020
| #. Execute ``composer require symfony/web-server-bundle`` and use the ``server:run`` | ||
| command to browse to the new route and see if the bug appears or not. | ||
| #. Install the :doc:`local web server </setup/symfony_server>` provided by Symfony | ||
| and use the ``symfony server:start`` command to browse to the new route and |
There was a problem hiding this comment.
„serve“ is just an alias. „server:start“ is fine 👌🏻
There was a problem hiding this comment.
server:start is also an alias :D
There was a problem hiding this comment.
Both look equally correct to me ... so, to not waste much time discussing about this ... let's merge "as is" 😄
|
Thank you @MrYamous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a webserver bundle usage in documentation from 5.0 according to his removal in Symfony 5.0