Skip to content

Remove webserver bundle usage #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Remove webserver bundle usage #13304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contributing/code/reproducer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ to a route definition. Then, after creating your project:
of controllers, actions, etc. as in your original application.
#. Create a small controller and add your routing definition that shows the bug.
#. Don't create or modify any other file.
#. Execute ``composer require symfony/web-server-bundle`` and use the ``server:run``
command to browse to the new route and see if the bug appears or not.
#. Install the :doc:`local web server </setup/symfony_server>` provided by Symfony
and use the ``symfony server:start`` command to browse to the new route and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony serve?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

„serve“ is just an alias. „server:start“ is fine 👌🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server:start is also an alias :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh really ? 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both look equally correct to me ... so, to not waste much time discussing about this ... let's merge "as is" 😄

see if the bug appears or not.
#. If you can see the bug, you're done and you can already share the code with us.
#. If you can't see the bug, you must keep making small changes. For example, if
your original route was defined using XML, forget about the previous route
Expand Down