Skip to content

Update mailer.rst #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Update mailer.rst #13895

merged 1 commit into from
Jun 26, 2020

Conversation

ThomasLandauer
Copy link
Contributor

Follow-up of symfony/symfony#37313 (comment)

Explaining how to "verify" successful delivery by catching the TransportException

@ThomasLandauer
Copy link
Contributor Author

Don't know what went wrong at "CI / Build"

@javiereguiluz javiereguiluz merged commit 66dbcb6 into symfony:4.4 Jun 26, 2020
@javiereguiluz
Copy link
Member

Thomas, thanks a lot for this contribution. This was an important missing thing in the docs. While merging I did some tweaks though.

First, I renamed the section from Catching Transport Exceptions to a more generic Handling Sending Failures, which can be expanded later with more problems and/or solutions.

Then, I moved the caution message at the top of the section and turned it into normal text ... because I think it's important to explain what Symfony considers successful and failed email sending.

@ThomasLandauer ThomasLandauer deleted the patch-13 branch June 26, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants