Update AbstractTransport.php

[ThomasLandauer]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

Removing ? from return type.
According to line 66, a SentMessage is returned in any case, isn't it?

If you agree, this change should be reflected in extending classes as well, e.g. https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php#L129

Question: What's the recommended way to check if the mail has been sent successfully? I didn't find anything better than $sentMessage->getDebug() yet...

[nicolas-grekas]

👎 this change breaks child classes that want to return null.

[ThomasLandauer]

Well, OK, but I couldn't find any such child class. Most Transports just do parent::send(), e.g. https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php#L132

However, the answer to my main question (check if message was sent successfully) seems to be to wrap the ->send() in a try and catch a Symfony\Component\Mailer\Exception\TransportException, right? => Should I go ahead and come up with a PR to explain this at https://symfony.com/doc/4.4/mailer.html ?

[fabpot]

You should catch the interface instead: Symfony\Component\Mailer\Exception\TransportExceptionInterface. Closing this PR and indeed, a fix in the docs would be great. Thank you.

[ThomasLandauer]

Sure, see symfony/symfony-docs#13895