Encore dev-server: re-add host check warning #14929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
re-add-host-check-warning
branch
from
92a7547 to
47d7639
Compare
weaverryan
commented
Feb 5, 2021
| @@ -113,3 +116,4 @@ your page. HMR works automatically with CSS (as long as you're using the | |||
| CSS. That is no longer needed. | |||
|
|
|||
| .. _`webpack-dev-server`: https://webpack.js.org/configuration/dev-server/ | |||
| .. _`it's not recommended to disable the firewall`: https://webpack.js.org/configuration/dev-server/#devserverdisablehostcheck | |||
There was a problem hiding this comment.
This is a little odd because this links to a different option.. the problem is that dev-server v4 still is in beta, and its docs don't exist. The disable-host-check v3 === firewall v4 (is my understanding)
|
Thank you Ryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #14895 (comment)