Skip to content

Encore dev-server: re-add host check warning #14929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Encore dev-server: re-add host check warning #14929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/encore/dev-server.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ the ``firewall`` option:
options.firewall = false;
})

Beware that `it's not recommended to disable the firewall`_ in general, but
here it's required to solve the CORS issue.

Hot Module Replacement HMR
--------------------------

Expand All @@ -113,3 +116,4 @@ your page. HMR works automatically with CSS (as long as you're using the
CSS. That is no longer needed.

.. _`webpack-dev-server`: https://webpack.js.org/configuration/dev-server/
.. _`it's not recommended to disable the firewall`: https://webpack.js.org/configuration/dev-server/#devserverdisablehostcheck
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little odd because this links to a different option.. the problem is that dev-server v4 still is in beta, and its docs don't exist. The disable-host-check v3 === firewall v4 (is my understanding)