Skip to content

Update pull_requests.rst #15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Update pull_requests.rst #15818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions contributing/code/pull_requests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ Check that the current Tests Pass
Now that Symfony is installed, check that all unit tests pass for your
environment as explained in the dedicated :doc:`document <tests>`.

.. tip::

If tests are failing, check on `Travis-CI`_ if the same test is
failing there as well. In that case you do not need to be concerned
about the test failing locally.

.. _step-2-work-on-your-patch:

Step 3: Work on your Pull Request
Expand Down Expand Up @@ -252,7 +246,7 @@ in mind the following:
as defined in `PSR-1`_ and `PSR-2`_.

A status is posted below the pull request description with a summary
of any problems it detects or any `Travis-CI`_ build failures.
of any problems it detects or any GitHub Actions build failures.

.. _prepare-your-patch-for-submission:

Expand Down Expand Up @@ -533,6 +527,5 @@ before merging.
.. _`PSR-2`: https://www.php-fig.org/psr/psr-2/
.. _`searching on GitHub`: https://github.com/symfony/symfony/issues?q=+is%3Aopen+
.. _`Symfony Slack`: https://symfony.com/slack-invite
.. _`Travis-CI`: https://travis-ci.org/symfony/symfony
.. _`Psalm phar is installed`: https://psalm.dev/docs/running_psalm/installation/
.. _`Contributing Back To Symfony`: https://symfonycasts.com/screencast/contributing