Correct spelling & grammar in 4.4 components/cache/ #16258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 14, 2021
| @@ -7,7 +7,7 @@ Cache Invalidation | |||
|
|
|||
| Cache invalidation is the process of removing all cached items related to a | |||
| change in the state of your model. The most basic kind of invalidation is direct | |||
| items deletion. But when the state of a primary resource has spread across | |||
| item deletion. But when the state of a primary resource has spread across | |||
There was a problem hiding this comment.
Not sure this change is correct
There was a problem hiding this comment.
It can either be stated as:
- ... is direct item deletion, or
- ... is the direct deletion of items.
| @@ -47,7 +47,7 @@ you can invalidate the cached items by calling | |||
| // if you know the cache key, you can also delete the item directly | |||
| $cache->delete('cache_key'); | |||
|
|
|||
| Using tags invalidation is very useful when tracking cache keys becomes difficult. | |||
| Using tag invalidation is very useful when tracking cache keys becomes difficult. | |||
There was a problem hiding this comment.
It can either be stated as:
- Using tag invalidation..., or
- Using the invalidation of tags...
nicolas-grekas
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.