Skip to content

Correct spelling & grammar in 4.4 components/cache/ #16258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/cache/adapters/php_array_cache_adapter.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ PHP Array Cache Adapter

This adapter is a high performance cache for static data (e.g. application configuration)
that is optimized and preloaded into OPcache memory storage. It is suited for any data that
is mostly read-only after warmup::
is mostly read-only after warm-up::

use Symfony\Component\Cache\Adapter\FilesystemAdapter;
use Symfony\Component\Cache\Adapter\PhpArrayAdapter;
Expand All @@ -23,7 +23,7 @@ is mostly read-only after warmup::
$cache = new PhpArrayAdapter(
// single file where values are cached
__DIR__ . '/somefile.cache',
// a backup adapter, if you set values after warmup
// a backup adapter, if you set values after warm-up
new FilesystemAdapter()
);
$cache->warmUp($values);
Expand Down
2 changes: 1 addition & 1 deletion components/cache/adapters/redis_adapter.rst
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ try to add data when no memory is available. An example setting could look as fo
maxmemory 100mb
maxmemory-policy allkeys-lru

Read more about this topic in the offical `Redis LRU Cache Documentation`_.
Read more about this topic in the official `Redis LRU Cache Documentation`_.

.. _`Data Source Name (DSN)`: https://en.wikipedia.org/wiki/Data_source_name
.. _`Redis server`: https://redis.io/
Expand Down
4 changes: 2 additions & 2 deletions components/cache/cache_invalidation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Cache Invalidation

Cache invalidation is the process of removing all cached items related to a
change in the state of your model. The most basic kind of invalidation is direct
items deletion. But when the state of a primary resource has spread across
item deletion. But when the state of a primary resource has spread across
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this change is correct

cc @nicolas-grekas @Nyholm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can either be stated as:

  • ... is direct item deletion, or
  • ... is the direct deletion of items.

several cached items, keeping them in sync can be difficult.

The Symfony Cache component provides two mechanisms to help solve this problem:
Expand Down Expand Up @@ -47,7 +47,7 @@ you can invalidate the cached items by calling
// if you know the cache key, you can also delete the item directly
$cache->delete('cache_key');

Using tags invalidation is very useful when tracking cache keys becomes difficult.
Using tag invalidation is very useful when tracking cache keys becomes difficult.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can either be stated as:

  • Using tag invalidation..., or
  • Using the invalidation of tags...


Tag Aware Adapters
~~~~~~~~~~~~~~~~~~
Expand Down