Fixing syntax for opening note block so notes render correctly #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,7 +371,7 @@ but getting an up to date configuration whilst developing your application:: | |||
| // ... | |||
| $container->compile(); | |||
|
|
|||
| if(!$isDebug) | |||
| if(!$isDebug) | |||
There was a problem hiding this comment.
Although it isn't your mistake, could you please make this correct? It should be:
if (!$isDebug) {
There was a problem hiding this comment.
Done - it probably was my mistake just not in this PR :)
There was a problem hiding this comment.
@richardmiller it isn't correct now, you forgot the opening bracket (or am I missing someting?)
There was a problem hiding this comment.
@wouterj no I missed that it was the missing brace rather than the missing space that you were pointing out. I have added it now
weaverryan
added a commit
that referenced
this pull request
Sep 18, 2012
Fixing syntax for opening note block so notes render correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of note blocks are rendering as php code examples due to some spaces I missed in the
.. note::syntax