Skip to content

Fixing syntax for opening note block so notes render correctly #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2012
Merged

Fixing syntax for opening note block so notes render correctly #1715

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a372aa1
Fixing syntax for opening note block so notes render correctly
richardmiller-zz Sep 16, 2012
e2d360f
Minor cs fix
richardmiller-zz Sep 16, 2012
b7a1e36
adding missing brace
richardmiller-zz Sep 16, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/dependency_injection/compilation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Compiling the Container

The service container can be compiled for various reasons. These reasons
include checking for any potential issues such as circular references and
making the container more efficient by resolving parameters and removing
making the container more efficient by resolving parameters and removing
unused services.

It is compiled by running::
Expand Down Expand Up @@ -170,7 +170,7 @@ the XML configuration::
return 'http://www.example.com/symfony/schema/';
}

..note::
.. note::

XSD validation is optional, returning ``false`` from the ``getXsdValidationBasePath``
method will disable it.
Expand All @@ -192,7 +192,7 @@ The XML version of the config would then look like this:

</container>

..note::
.. note::

In the Symfony2 full stack framework there is a base Extension class which
implements these methods as well as a shortcut method for processing the
Expand Down Expand Up @@ -371,7 +371,7 @@ but getting an up to date configuration whilst developing your application::
// ...
$container->compile();

if(!$isDebug)
if(!$isDebug)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it isn't your mistake, could you please make this correct? It should be:

if (!$isDebug) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - it probably was my mistake just not in this PR :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardmiller it isn't correct now, you forgot the opening bracket (or am I missing someting?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj no I missed that it was the missing brace rather than the missing space that you were pointing out. I have added it now

$dumper = new PhpDumper($container);
file_put_contents($file, $dumper->dump(array('class' => 'MyCachedContainer')));
}
Expand Down