Skip to content

[ExpressionLanguage] Fix redirects and revert merging reference docs with the main guide #17726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jan 12, 2023

Ref #17724 (comment) for more information about why I believe we shouldn't want to merge the syntax doc in the main guide.

@wouterj wouterj force-pushed the expressionlanguage-merge branch from 3e97d17 to aafefcf Compare January 12, 2023 11:59
@OskarStark OskarStark requested a review from fabpot January 13, 2023 07:35
@fabpot
Copy link
Member

fabpot commented Jan 13, 2023

Merging the spec with the main doc is what we've done for YAML, so it seems consistent to me.
I've no strong opinion though.

@wouterj
Copy link
Member Author

wouterj commented Jan 13, 2023

Ah, I've missed that move. I must say that I think the same thing about that, I would prefer to keep a separate Yaml syntax reference.

@fabpot
Copy link
Member

fabpot commented Jan 16, 2023

What about moving the YAML and expression language syntax docs under reference/ then?

@xabbuh
Copy link
Member

xabbuh commented Jan 17, 2023

What about moving the YAML and expression language syntax docs under reference/ then?

sounds like a good idea to me

@fabpot
Copy link
Member

fabpot commented Jan 27, 2023

Taking over here: #17817

@fabpot
Copy link
Member

fabpot commented Jan 27, 2023

Closing as the other PR has been merged.

@fabpot fabpot closed this Jan 27, 2023
@wouterj wouterj deleted the expressionlanguage-merge branch January 27, 2023 16:47
@wouterj
Copy link
Member Author

wouterj commented Jan 27, 2023

Thank you Fabien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants