Skip to content

Fix $tags type #18647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Fix $tags type #18647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a532a2
Backport a fix related to Webpack Encore
javiereguiluz Jul 31, 2023
d2c02fa
Merge branch '5.4' into 6.2
javiereguiluz Jul 31, 2023
88655a9
Fix $tags type
devojifr Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions form/form_collections.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Let's start by creating a ``Task`` entity::
class Task
{
protected string $description;
protected ArrayCollection $tags;
protected Collection $tags;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArrayCollection use statement can be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this while merging. Thanks.


public function __construct()
{
Expand Down Expand Up @@ -466,7 +466,7 @@ you will learn about next!).
// ...

#[ORM\ManyToMany(targetEntity: Tag::class, cascade: ['persist'])]
protected array $tags;
protected Collection $tags;

.. code-block:: yaml

Expand Down
6 changes: 3 additions & 3 deletions frontend/encore/simple-example.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,19 +430,19 @@ Encore. When you do, you'll see an error!
.. code-block:: terminal

> Error: Install sass-loader & sass to use enableSassLoader()
> yarn add sass-loader@^12.0.0 sass --dev
> yarn add sass-loader@^13.0.0 sass --dev

Encore supports many features. But, instead of forcing all of them on you, when
you need a feature, Encore will tell you what you need to install. Run:

.. code-block:: terminal

# if you use the Yarn package manager
$ yarn add sass-loader@^12.0.0 sass --dev
$ yarn add sass-loader@^13.0.0 sass --dev
$ yarn encore dev --watch

# if you use the npm package manager
$ npm install sass-loader@^12.0.0 sass --save-dev
$ npm install sass-loader@^13.0.0 sass --save-dev
$ npm run watch

Your app now supports Sass. Encore also supports LESS and Stylus. See
Expand Down