Skip to content

Cookbook/Console/ConsoleCommand : Adding option/argument example in test #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gregquat
Copy link
Contributor

@gregquat gregquat commented Jul 3, 2013

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Jul 3, 2013

Are there any particular reasons why you want to extend the example?

Besides, you should base your pull request on the 2.2 branch.

@gregquat
Copy link
Contributor Author

gregquat commented Jul 3, 2013

Mmm I immediately see 2 reasons :

  • I would like to test my command with required parameters, and I had to find the answer on stackoverflow.
  • I do not see any reason to not add it since an example has to be as complete as possible.

I'll make another PR on the 2.2 branch. I did not see that the 2.1 has been deprecated since my last PR.

gregquat added a commit to gregquat/symfony-docs that referenced this pull request Jul 3, 2013
@gregquat
Copy link
Contributor Author

gregquat commented Jul 3, 2013

Another PR (#2793) has been made on the 2.2 branch

@gregquat gregquat closed this Jul 3, 2013
@gregquat gregquat deleted the patch-17 branch July 3, 2013 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants