Mentioned that form related services can now be private #7823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Apr 19, 2017
HeahDude
reviewed
Apr 19, 2017
form/create_form_type_extension.rst
Outdated
| defaults to ``0`` and controls the order in which the form | ||
| type extensions are loaded (the higher the priority, the earlier | ||
| an extension is loaded). This is useful when you need to guarantee | ||
| There is an optional tag attribute called ``priority``, which |
There was a problem hiding this comment.
CS fixes should be back ported in 2.7, right?
There was a problem hiding this comment.
You are right. I've reverted all those changes to avoid conflicts. Thanks!
form/create_form_type_extension.rst
Outdated
| @@ -131,12 +131,16 @@ The ``extended_type`` key of the tag is the type of field that this extension sh | |||
| be applied to. In your case, as you want to extend the ``Symfony\Component\Form\Extension\Core\Type\FileType`` | |||
| field type, you will use that as the ``extended_type``. | |||
|
|
|||
| .. versionadded:: 3.3 | |||
| Prior to Symfony 3.3, you needed to define form extension services as ``public``. | |||
There was a problem hiding this comment.
"[...] define type extension services [...]"
This is needed because there are also form extensions, but we do not register them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7687.