-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Mentioned that form related services can now be private #7823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -131,12 +131,16 @@ The ``extended_type`` key of the tag is the type of field that this extension sh | |
be applied to. In your case, as you want to extend the ``Symfony\Component\Form\Extension\Core\Type\FileType`` | ||
field type, you will use that as the ``extended_type``. | ||
|
||
.. versionadded:: 3.3 | ||
Prior to Symfony 3.3, you needed to define form extension services as ``public``. | ||
Starting from Symfony 3.3, you can also define them as ``private``. | ||
|
||
.. tip:: | ||
|
||
There is an optional tag attribute called ``priority``, which | ||
defaults to ``0`` and controls the order in which the form | ||
type extensions are loaded (the higher the priority, the earlier | ||
an extension is loaded). This is useful when you need to guarantee | ||
There is an optional tag attribute called ``priority``, which | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CS fixes should be back ported in 2.7, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. I've reverted all those changes to avoid conflicts. Thanks! |
||
defaults to ``0`` and controls the order in which the form | ||
type extensions are loaded (the higher the priority, the earlier | ||
an extension is loaded). This is useful when you need to guarantee | ||
that one extension is loaded before or after another extension. | ||
|
||
.. versionadded:: 3.2 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"[...] define type extension services [...]"
This is needed because there are also form extensions, but we do not register them.