Update lockable_trait.rst for blocking lock #8076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method lock() of LockableTrait accept 2 parameters, the first one is the name used to create the lock file, and the second is a value indicating if we should wait until the lock is release. Thus, the line $this->lock(true); should be $this->lock('someRandomLockName', true);
xabbuh
reviewed
Jun 22, 2017
console/lockable_trait.rst
Outdated
| @@ -30,7 +30,7 @@ that adds two convenient methods to lock and release commands:: | |||
| } | |||
|
|
|||
| // If you prefer to wait until the lock is released, use this: | |||
| // $this->lock(true); | |||
| // $this->lock('lockname', true); | |||
There was a problem hiding this comment.
What about passing null as the first argument instead to use the default lock name?
There was a problem hiding this comment.
null could do the trick as any string. Using null result in using the name define for the command. My point is to use the blocking functionnality of the trait, we need to add a first parameter before true.
javiereguiluz
approved these changes
Jul 6, 2017
There was a problem hiding this comment.
I've made the change requested by @xabbuh to move faster and make this mergeable.
By the way, now that we have the Lock component, I wonder if we should keep using this LockableTrait.
|
Thank you @lpussacq. |
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
…viereguiluz)
This PR was merged into the 3.2 branch.
Discussion
----------
Update lockable_trait.rst for blocking lock
The method lock() of LockableTrait accept 2 parameters, the first one is the name used to create the lock file, and the second is a value indicating if we should wait until the lock is release. Thus, the line $this->lock(true); should be $this->lock('someRandomLockName', true);
Commits
-------
7c99b93 Use "null" so the lock is named automatically
615817e Update lockable_trait.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method lock() of LockableTrait accept 2 parameters, the first one is the name used to create the lock file, and the second is a value indicating if we should wait until the lock is release. Thus, the line $this->lock(true); should be $this->lock('someRandomLockName', true);