Skip to content

Update lockable_trait.rst for blocking lock #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2017
Merged

Update lockable_trait.rst for blocking lock #8076

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
615817e
Update lockable_trait.rst
lpussacq Jun 22, 2017
7c99b93
Use "null" so the lock is named automatically
javiereguiluz Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/lockable_trait.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ that adds two convenient methods to lock and release commands::
}

// If you prefer to wait until the lock is released, use this:
// $this->lock(true);
// $this->lock('lockname', true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about passing null as the first argument instead to use the default lock name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null could do the trick as any string. Using null result in using the name define for the command. My point is to use the blocking functionnality of the trait, we need to add a first parameter before true.


// ...

Expand Down