Clarifying usage of delivery_whitelist #8575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was nothing to suggest that `delivery_whitelist` could not be used on its own. We had to find this out by trial an error. Hopefully, this change (or better equivalent) will help other people. Cheers.
wouterj
approved these changes
Nov 2, 2017
marcverney
suggested changes
Nov 2, 2017
email/dev_environment.rst
Outdated
| @@ -190,6 +190,10 @@ In the above example all email messages will be redirected to ``[email protected]` | |||
| and messages sent to the ``[email protected]`` address or to any email address | |||
| belonging to the domain ``specialdomain.com`` will also be delivered as normal. | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| The ``delivery_whitelist`` option can only be used in conjuction with the ``delivery_addresses`` option. | |||
There was a problem hiding this comment.
Can we reword this to make it easier to read? Something like this:
The ``delivery_whitelist`` option is ignored when the ``delivery_addresses``
option is not defined.
There was a problem hiding this comment.
What about this:
The delivery_whitelist option is ignored unless the delivery_addresses option is defined.
There was a problem hiding this comment.
Nice and concise! I like it. Thanks!
|
I need to squash these commits into a single commit, right? |
|
@tomhv there's no need because we use a tool that squashes everything automatically. Cheers! |
|
Thank you @tomhv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was nothing to suggest that
delivery_whitelistcould not be used on its own. We had to find this out by trial an error.Hopefully, this change (or better equivalent) will help other people.
Cheers.