Skip to content

[Icons] Add InMemory registry to allow easier tests #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Mar 9, 2024

Will come handy to test the IconRenderer

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 9, 2024
@kbond
Copy link
Member

kbond commented Mar 9, 2024

As discussed in Slack, do we want to make this a configuration option?

Allowing this to be used as the only registry in your test environment could save a ton of http requests for apps that extensively use the on demand system.

@smnandre
Copy link
Member Author

smnandre commented Mar 9, 2024

Yep that was on my mind.. But i rather go step by step there, as i'm sure i need the InMemoryRegistry to add feature + test the Renderer :)

You ok if we add the config/test thing in another PR ?

@kbond
Copy link
Member

kbond commented Mar 10, 2024

Could you show an example of how you intend this to be used by end users?

@kbond kbond force-pushed the feat/in-memory-registry branch from 372cd76 to dfd6a2a Compare March 10, 2024 17:49
@kbond
Copy link
Member

kbond commented Mar 10, 2024

Thanks Simon.

@kbond kbond merged commit 3bcc9d6 into symfony:2.x Mar 10, 2024
@smnandre
Copy link
Member Author

Could you show an example of how you intend this to be used by end users?

First example there (internal so that's not the answer you expected ... but it's a start)

#1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants