[Icons] Test IconRenderer #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Mar 10, 2024
norkunas
reviewed
Mar 10, 2024
smnandre
force-pushed
the
icons/test-icon-renderer
branch
from
a7e9c2f to
f181098
Compare
kbond
approved these changes
Mar 10, 2024
carsonbot
added
Status: Reviewed
|
can you fix the cs |
|
Good now |
|
needs the license on |
|
Arf sorry |
kbond
force-pushed
the
icons/test-icon-renderer
branch
from
486c5a1 to
e33253c
Compare
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create tests for the IconRenderer
Add internal docblock to clarify the attributes precedence
(+ one CS fix passing by)
--
testsdirectoryAs @kbond says, it won't be used by final users so it's better there