Skip to content

[Icons] Add Icon + Iconify tests #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

[Icons] Add Icon + Iconify tests #1617

merged 1 commit into from
Mar 21, 2024
+175 −36

Conversation

smnandre
Copy link
Member

Add missing tests on Icon attributes (html + with/out)

(before making changes to the Renderer)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 12, 2024
@norkunas
Copy link
Contributor

norkunas commented Mar 19, 2024 •
edited
Loading

How it's possible to use attributes.without when using <twig:UX:Icon /> ?
I mean - I have css class that sets for all icons width/height, so there is no point to render icons with these attributes, how I could remove them from the output?

@smnandre
Copy link
Member Author

This is planned, and i understand very well your need, as i have the same :)

@smnandre
Copy link
Member Author

FYI this PR is one of the steps required ;)

@smnandre smnandre force-pushed the icons/test-icon-attributes branch 3 times, most recently from e9d9ea7 to 0371bbf Compare March 20, 2024 23:46
@smnandre smnandre mentioned this pull request Mar 20, 2024
Closed
@smnandre smnandre changed the title [Icons] Test Icon attributes [Icons] Add Icon + Iconify tests Mar 21, 2024
kbond
kbond requested changes Mar 21, 2024
View reviewed changes
@carsonbot carsonbot added Status: Needs Work Additional work is needed Status: Needs Review Needs to be reviewed and removed Status: Needs Review Needs to be reviewed Status: Needs Work Additional work is needed labels Mar 21, 2024
@kbond kbond force-pushed the icons/test-icon-attributes branch from 40afb36 to ad25b69 Compare March 21, 2024 14:52
@kbond
Copy link
Member

kbond commented Mar 21, 2024

Thank you Simon.

@kbond kbond merged commit 625a784 into symfony:2.x Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond requested changes

Assignees
No one assigned
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @norkunas @kbond @carsonbot