-
-
Notifications
You must be signed in to change notification settings - Fork 84
Allow disabling default build if multiple entry points are defined #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
191a60c
to
b6db7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @emodric!
Sorry for the slow attention on this. I merged another PR and created conflicts with this one - could you check those?
I'm +1 for this PR. However, I'm interested in what the error is if you disable the default entrypoint, and then accidentally use a feature without specifying which build you want - I think the user will see errors like "The build _default does not exist" - which isn't a great error.
#45 will also help and affect this PR |
@weaverryan Will get back to you next week, can't get to it any sooner. |
b6db7e1
to
dbdaaaa
Compare
@weaverryan I've pushed the rebased commit. As for #45, how will it help and affect this PR? When someone uses a default build which has been disabled, the error message is: Maybe we could try to determine which builds are configured and offer them as an alternative in the error message, e.g: |
Hello @emodric do you plan to merge this pr anytime soon? |
You should probably be asking @weaverryan that :) |
@emodric Thanks for the info :) |
Sorry about the slow merge on this - it's a really great PR. Even the README got updated! Thank you Edi! |
@weaverryan Thanks for the merge :) However, what about this part, that you were initially concerned about?
|
…is enabled (emodric) This PR was merged into the master branch. Discussion ---------- Only add alias to EntrypointLookupInterface if default build is enabled Caused by the combination of 64f1e94 and #37 The commit in question was added after the commits in my PR #37, so it slipped through the cracks. Commits ------- 315955f Only add alias to EntrypointLookupInterface if default built is enabled
Fixes #32.