Skip to content

Allowing new major versions of outdated dependencies #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 2, 2022

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Aug 31, 2021

Fixes #1029

A bit more work to do. For now, I'm focused only on the main dependencies (not the devDependencies).

You could argue that this will require a new major version of webpack-encore. However, there is a precedence for allowing major dependency upgrades on minor versions in the past: https://github.com/symfony/webpack-encore/releases/tag/v1.2.0. Assuming none of the libraries have underlying changes that are likely to affect users, I'd like to do that again. Edit: likely we should have a new major release.

Dependencies

  • chalk: kept at v4 because v5 requires esm. v4 is stable.
  • clean-webpack-plugin: 3->4 No breaking changes
  • css-loader: 5->6: Min node to 12.3.0, other changes: CHANGELOG
  • css-minimizer-webpack-plugin: 2->3 Min node to 12.3.0
  • loader-utils: REMOVED
  • mini-css-extract-plugin 1.5->2.2.1 Min node to 12.13.0, Webpack to 5.0.0, other changes: CHANGELOG
  • pkg-up: Keeping version 3.1 because 4 requires esm.
  • pretty-error: 3.0->4.0 Min node to 12.0
  • resolve-url-loader 3.0->5.0 Min node to 12.0, postcss ^8.0, remove rework engine, other changes: CHANGELOG
  • style-loader: 2->3 Min node to 12.13, Min webpack to 5.0 other changes: CHANGELOG
  • yargs-parser: 20.2->21 Min node to 12.0

Dev Dependencies

  • eslint: 7->8 Min node to 12.22
  • eslint-webpack-plugin: 2.5->3 min node to 12. Min webpack 5
  • fork-ts-checker-webpack-plugin: 5->6 CHANGELOG
  • fs-extra: 9->10 Min node to 12. Potentially breaking changes: CHANGELOG
  • http-server: 0.12->14 Min node to 12.
  • less-loader: 7->10: Min node to 12. Min webpack to 5. less.webpackLoaderContext was removed, please use pluginManager.webpackLoaderContext
  • mocha: 8->9: min node to 12. CHANGELOG
  • postcss-loader: 4-5->6: min node to 12. min webpack to 5.
  • preact: 8->10: CHANGELOG
  • sass-loader: 9-10-11->12 min node to 12.13. Min webpack to 5
  • sinon: 9->12
  • strip-ansi: Need to keep 6 because 7 is esm only. Min node to 12
  • stylus: 0.54->0.56
  • stylus-loader: 3-4-5->6: Min node to 12.13. Min webpack to 5. Other breaking changes: CHANGELOG

TODOs:

  • A) Check CHANGELOG of each library to see what changes, if any, we need.
  • B) Bump our CHANGELOG for changes people should watch out for
  • C) Get tests passing

@tropicalraisel
Copy link

tropicalraisel commented Sep 1, 2021

Based on Webpack's changelogs, there shouldn't be anything that stops jumping from v5.35 to v5.51.1.

@weaverryan weaverryan force-pushed the bump-main-dependencies branch from 2809bd6 to f3d1496 Compare January 21, 2022 01:24
@weaverryan weaverryan added this to the Encore 2.0 milestone Jan 21, 2022
@stof
Copy link
Member

stof commented Jan 21, 2022

@weaverryan what is the state of this ?

@shadowc
Copy link

shadowc commented Mar 21, 2022

Adding some more info about packages:

  • mini-css-extract-plugin: 1.5->2.2.1 Min node to 12.13.0, Webpack to 5.0.0, other changes: CHANGELOG
  • pkg-up: Keeping version 3.1 because 4 requires esm.
  • pretty-error: 3.0->4.0 Min node to 12.0
  • resolve-url-loader 3.0->5.0 Min node to 12.0, postcss ^8.0, remove rework engine, other changes: CHANGELOG
  • style-loader: 2->3 Min node to 12.13, Min webpack to 5.0 other changes: CHANGELOG
  • yargs-parser: 20.2->21 Min node to 12.0

@shadowc
Copy link

shadowc commented Mar 22, 2022

More info about devDependencies:

  • eslint: 7->8 Min node to 12.22
  • eslint-webpack-plugin: 2.5->3 min node to 12. Min webpack 5
  • fork-ts-checker-webpack-plugin: 5->6 CHANGELOG
  • fs-extra: 9->10 Min node to 12. Potentially breaking changes: CHANGELOG
  • http-server: 0.12->14 Min node to 12.
  • less-loader: 7->10: Min node to 12. Min webpack to 5. less.webpackLoaderContext was removed, please use pluginManager.webpackLoaderContext
  • mocha: 8->9: min node to 12. CHANGELOG
  • postcss-loader: 4-5->6: min node to 12. min webpack to 5.
  • preact: 8->10: CHANGELOG
  • sass-loader: 9-10-11->12 min node to 12.13. Min webpack to 5
  • sinon: 9->12
  • strip-ansi: Need to keep 6 because 7 is esm only. Min node to 12
  • stylus: 0.54->0.56
  • stylus-loader: 3-4-5->6: Min node to 12.13. Min webpack to 5. Other breaking changes: CHANGELOG

@weaverryan weaverryan force-pushed the bump-main-dependencies branch from b4a5871 to 993e364 Compare April 22, 2022 00:20
@weaverryan weaverryan force-pushed the bump-main-dependencies branch 2 times, most recently from f36782c to 66fe09f Compare April 22, 2022 17:29
At some point, in order to use `@babel/eslint-parser`, this became required.
@weaverryan weaverryan force-pushed the bump-main-dependencies branch from 66fe09f to a7d817d Compare April 22, 2022 17:37
Also bumping two other dependencies
Also bumping min versions of other deps
Also bumping Webpack to latest - was missed earlier
@weaverryan weaverryan changed the title [WIP] allowing new major versions of outdated dependencies Allowing new major versions of outdated dependencies Apr 22, 2022
@weaverryan
Copy link
Member Author

This is now ready!

@weaverryan weaverryan merged commit b2456a9 into symfony:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies!
4 participants