-
-
Notifications
You must be signed in to change notification settings - Fork 199
Allowing new major versions of outdated dependencies #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Webpack's changelogs, there shouldn't be anything that stops jumping from |
2809bd6
to
f3d1496
Compare
@weaverryan what is the state of this ? |
Adding some more info about packages:
|
More info about
|
b4a5871
to
993e364
Compare
f36782c
to
66fe09f
Compare
At some point, in order to use `@babel/eslint-parser`, this became required.
66fe09f
to
a7d817d
Compare
Also bumping two other dependencies
Also bumping min versions of other deps
Also bumping Webpack to latest - was missed earlier
This is now ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029
A bit more work to do. For now, I'm focused only on the main dependencies (not thedevDependencies
).You could argue that this will require a new major version of webpack-encore. However, there is a precedence for allowing major dependency upgrades on minor versions in the past: https://github.com/symfony/webpack-encore/releases/tag/v1.2.0. Assuming none of the libraries have underlying changes that are likely to affect users, I'd like to do that again.Edit: likely we should have a new major release.Dependencies
: kept at v4 because v5 requires esm. v4 is stable.chalk
clean-webpack-plugin
:3->4
No breaking changescss-loader
:5->6
: Min node to 12.3.0, other changes: CHANGELOGcss-minimizer-webpack-plugin
:2->3
Min node to 12.3.0loader-utils
: REMOVED1.5->2.2.1
Min node to 12.13.0, Webpack to 5.0.0, other changes: CHANGELOG: Keeping versionpkg-up
3.1
because4
requires esm.pretty-error
:3.0->4.0
Min node to 12.0resolve-url-loader
3.0->5.0
Min node to 12.0, postcss ^8.0, removerework
engine, other changes: CHANGELOGstyle-loader
:2->3
Min node to 12.13, Min webpack to 5.0 other changes: CHANGELOGyargs-parser
:20.2->21
Min node to 12.0Dev Dependencies
eslint
:7->8
Min node to12.22
eslint-webpack-plugin
:2.5->3
min node to12
. Min webpack5
fork-ts-checker-webpack-plugin
:5->6
CHANGELOGfs-extra
:9->10
Min node to12
. Potentially breaking changes: CHANGELOGhttp-server
:0.12->14
Min node to12
.less-loader
:7->10
: Min node to12
. Min webpack to5
.less.webpackLoaderContext
was removed, please usepluginManager.webpackLoaderContext
mocha
:8->9
: min node to12
. CHANGELOGpostcss-loader
:4-5->6
: min node to12
. min webpack to5
.preact
:8->10
: CHANGELOGsass-loader
:9-10-11->12
min node to12.13
. Min webpack to5
sinon
:9->12
: Need to keepstrip-ansi
6
because7
is esm only. Min node to12
stylus
:0.54->0.56
stylus-loader
:3-4-5->6
: Min node to12.13
. Min webpack to5
. Other breaking changes: CHANGELOGvue-loader
:16-17
No important changes: https://github.com/vuejs/vue-loader/blob/next/CHANGELOG.md#1700-2021-12-12TODOs: