Skip to content

Upgrade to resolve-url-loader v5 #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stof
Copy link
Member

@stof stof commented Jan 21, 2022

This is a slight BC break in case someone configures the resolveUrlLoaderOptions when enabling the sass-loader.

BC breaks in that loader between v3 and v5:

  • node 12 is required (fine as Encore already requires it) not actually fine.
  • the engine option is gone, keeping only the postcss-based engine. The rework engine was not recommended anymore in v3, officially deprecated in v4 and removed in v5. given that the rework library is essentially unmaintained and has lots of bugs with modern CSS, I strongly doubt that any webpack-encore users would have made the choice to use that old engine instead of the default one
  • the join option changed the signature of the function. This is a very advanced customization option

This will avoid many warnings when installing dependencies:

  • rework depends on several unmaintained packages that have been deprecated in the npm registry
  • The postcss version used by this loader has been updated to postcss 8, which avoids the warning about postcss 7 being vulnerable to ReDoS.

@stof stof added the dependencies Pull requests that update a dependency file label Jan 21, 2022
@stof
Copy link
Member Author

stof commented Jan 21, 2022

Actually, I was wrong. Encore still supports node 10.

@weaverryan I strongly suggest doing a new major version of Encore bumping the min version to node 12 (or even node 14 as node 12 is EOL in April) instead of keeping support for the EOL node 10. More and more npm packages are bumping their min version.

@stof stof marked this pull request as draft January 21, 2022 11:06
@stof
Copy link
Member Author

stof commented Jan 21, 2022

btw, our CI uses yarn install --ignore-engines on node 10, which is a sign that we already do a mess there (which might hide warnings that projects using encore would see on node 10)

@weaverryan
Copy link
Member

weaverryan commented Jan 21, 2022

I was thinking about dropping 10 and doing a major release also. I have another PR - #1033 - open that upgrades EVERYTHING that’s out of date, with the idea of making the most out of our major release.

@weaverryan
Copy link
Member

btw, our CI uses yarn install --ignore-engines on node 10, which is a sign that we already do a mess there (which might hide warnings that projects using encore would see on node 10)

To match up with Ubuntu's LTS version, and its Node version, I was trying to hold onto Node 10 support as long as possible. But because of what you mentioned, it was already shaky.

@stof
Copy link
Member Author

stof commented Jan 21, 2022

@weaverryan I opened #1079 to discuss that.

@weaverryan
Copy link
Member

Closed in favor of #1033, which is ready now

@weaverryan weaverryan closed this Apr 22, 2022
@stof stof deleted the upgrade_resolve_url_loader branch April 18, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants