-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
e1a67bf
to
200ccd1
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There are two remaining test failures: ``` $ swift test --filter OptimizerTests Tests/TensorFlowTests/OptimizerTests.swift:117: error: -[TensorFlowTests.OptimizerTests testAdaMax] : XCTAssertTrue failed Tests/TensorFlowTests/OptimizerTests.swift:123: error: -[TensorFlowTests.OptimizerTests testAMSGrad] : XCTAssertTrue failed ```
6d1a850
to
ee249fa
Compare
Dense.bias
type to Optional
Dense.bias
type to Optional
Could you add a test to verify that this will work with |
CI fails for a test that seems related to key path iteration:
Closing for now because optional differentiation isn't fully supported (SR-13700), so usability wouldn't be great (if users can't differentiate through Investigating the test failure on this branch would be a great step towards a smooth migration to using |
TrivialModelTests.swift
test is currently failing.