This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Added support for 'isFinite', 'isInfinite', and 'isNaN'. #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Richard Wei <[email protected]>
rxwei
reviewed
May 31, 2019
rxwei
approved these changes
May 31, 2019
|
@rxwei I just updated this and all math tests pass locally, so it should be ready to merge. There are some failing tests related to lazy tensor that are not related to this PR. |
|
Also verified that all CI tests pass. |
|
@rxwei Is it ok to directly merge minor fixes like this one as long as CI tests pass? |
|
Yes, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names are not very swifty. @rxwei do you have any better suggestions? We could make them functions of
Tensor.