This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Added support for 'logSumExp'. #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you use the global |
eaplatanios
changed the title
|
I addressed that. It remains to add documentation and tests which I'll do later today. |
eaplatanios
changed the title
|
@rxwei I added documentation and tests. The CI tests are running now and so this only requires an approving review. |
|
CI tests pass so this is only pending a review. |
Yeah I saw your use case. I think this justifies having a top-level |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #149. @rxwei I was also relying on a general
Tensor.withoutDerivative()for this. It'd be nice to find a nice way to deal with this situation more generally.