-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[AutoDiff] Added support for 'withoutDerivative(at:)'. #25691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One question that remains is, given these new helpers do we want to keep the |
No, please feel free to remove it. |
Sounds good. I'll do that but I need to know how to replace this. Is there something along the lines of |
There is a |
Thanks! I made these edits and also changed the relevant tests. I cannot currently test locally so could you please run the CI tests so I check if the error reporting test modifications are correct? |
@swift-ci please test tensorflow |
1 similar comment
@swift-ci please test tensorflow |
The CI errors are due to swift-apis. I'll make a corresponding PR there and try to test locally a bit later today. |
@rxwei Tests seem to pass locally now. Could you please start the CI tests? |
@swift-ci please test tensorflow |
1 similar comment
@swift-ci please test tensorflow |
@swift-ci please clean test tensorflow |
@rxwei following from our discussion in tensorflow/swift-apis#150.