Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Removed all uses of 'Differentiable.withoutDerivative()'. #284

Merged
merged 3 commits into from
Jun 23, 2019
Merged

Removed all uses of 'Differentiable.withoutDerivative()'. #284

merged 3 commits into from
Jun 23, 2019

Conversation

eaplatanios
Copy link
Contributor

Friend PR of swiftlang/swift#25691.

cc @rxwei

rxwei
rxwei reviewed Jun 23, 2019
View reviewed changes
@eaplatanios
Copy link
Contributor Author

This requires the new toolchain anyway because of using withoutDerivative(at:) so we might as well remove Swift. and merge them both together. What do you think?

@eaplatanios
Copy link
Contributor Author

Actually nvm, to make this smoother I added in: identity for the two uses of Swift.withoutDerivative(at:). This will make it pass current CI tests. Then we can update the commit hash in apple/swift, test there, and after that is merged I'll make a small cleanup here.

@rxwei
Copy link
Contributor

rxwei commented Jun 23, 2019 •
edited
Loading

That sounds like a better option. A new toolchain will be ready later this afternoon.

@eaplatanios eaplatanios merged commit 6045403 into tensorflow:master Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rxwei rxwei rxwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eaplatanios @rxwei @kokoro-team