Adding conv transpose 1d & 3d #174
Conversation
|
I've added 1d transpose as well, this is something not found in the keras library. But could someone check the logic of that as well? I'll add the rest of the conv layers throughout the week. |
|
Note: The build passes. |
|
@rxwei Any updates on taking a look at this? |
rxwei
requested review from
rxwei and
dan-zheng
and removed request for
jekbradbury
|
@rxwei There seems to some disconnect between the tensorflow/Keras Convtranspose APIs and our APIs, could you help me write some tests for this? |
We will try to take a look later this week! |
|
@rxwei Updated this PR, the build and tests pass on the latest nightly. Sorry for the delay! |
|
done |
|
@rxwei could you approve this |
| @noDerivative public let strides: (Int, Int, Int) | ||
| /// The padding algorithm for convolution. | ||
| @noDerivative public let padding: Padding | ||
| @noDerivative public let paddingIndex: Int |
There was a problem hiding this comment.
Add a doc comment for this property.
There was a problem hiding this comment.
@rxwei this property isn't really exposed to the users, it's a temporary property which allows us to handle computation based on what kind of padding it is. we currently support .same and .valid.
Do we still document this?
| @noDerivative public let stride: Int | ||
| /// The padding algorithm for convolution. | ||
| @noDerivative public let padding: Padding | ||
| @noDerivative public let paddingIndex: Int |
There was a problem hiding this comment.
Add a doc comment for this property.
|
@Shashi456 I've been assigned to help move this PR over the finish line. At a glance, things are looking great :) If you could resolve the conflicts and add documentation comments for |
|
@burmako this property isn't really exposed to the users, it's a temporary property which allows us to handle computation based on what kind of padding it is. we currently support .same and .valid. |
|
@Shashi456 I think a comment along the following lines would be great: |
|
@burmako does this work? |
|
Thank you! I'll be merging now :) |
I'll add the tests. but till then could someone check the logic once and tell me if i'm wrong or right?